Use six.ensure_binary() to convert strings into bytes in _send_message(). #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timarmstrong and @swixx -- whenever you guys have a chance, can you have a look? I confirmed I could connect to a kerberized cluster with both python2 and 3. I don't know if there's anything else I need to test? |
wesm
reviewed
Dec 16, 2019
dknupp
force-pushed
the
use_bytearray_to_encode
branch
2 times, most recently
from
1a95ca6 to
5051434
Compare
dknupp
changed the title
Tagar
reviewed
Dec 18, 2019
This was referenced Feb 7, 2020
Closed
Pull request cloudera#17 addressed the issue whereby there were occasional concatenation problems when message header and mesage body were of different types. However, the original patch, which uses encode(), was not compatible with python 2 in cases where the body included characters that fell outside of the strict set of ASCII characters.
dknupp
force-pushed
the
use_bytearray_to_encode
branch
from
5051434 to
5e2930b
Compare
timarmstrong
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #17 addressed the issue whereby there were occasional
concatenation problems when message header and mesage body were of
different types. However, the original patch, which uses encode(),
was not compatible with python 2 in cases where the body included
characters that fell outside of the strict set of ASCII characters.