Fix erorrs in apache thrift compatibility

[igorivanov]

There are some errors in current Apache thrift compatibility in a thrift_sasl module - these changes remain from the previous version. This errors led to issue in impyla: cloudera/impyla#268

[mariusvniekerk]

I wonder if in the interest of compatibility with older thrift libraries we want to determine the method calls in a way that works with thrift 0.10 and 0.9

[dknupp]

Are there callers that rely on both isOpen() and is_open() being available? Why keep both? Could you just have:

  def is_open(self):
      return self._trans.is_open()

[andredasilvapinto]

Where does this self._trans.is_open() come from?

https://git1-us-west.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/py/src/transport/TSocket.py;h=c91de9d701f8e26f1fcadf2e2b4c6eb79bc7b3ed;hb=HEAD#l72

[mkurovski]

Is there some progress on this issue or can you merge it?

[mariusvniekerk]

@wesm ping

[wesm]

@gregrahn can someone test this out and make a release of the package?

[gregrahn]

@wesm 👍

[danielfrg]

+1 for a release soon if possible since latest versions pyhive and impyla have incompatible versions of thrift_sasl at the moment

[gregrahn]

@dknupp given you updated impyla to 0.14.1 on 2018-02-23, is this still an open issue?

[danielfrg]

impyla 0.14.1 pins thrift_sasl to 0.2.1 so it works but its still not possible to update thrift_sasl for other libraries that need it (PyHive with kerberos support and maybe others) so i think this is still an issue until a new release is made.