[ui-importer] Add Primary key column in bulk column modal #4281
Conversation
|
✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅ |
ananya-agarwal
requested review from
JohanAhlen,
bjornalm,
ramprasadagarwal and
tabraiz12
and removed request for
bjornalm
UI Code Coverage Report
|
Backend Code Coverage Report •
|
| setEditableRows(rows => | ||
| rows.map((row, i) => ({ | ||
| ...row, | ||
| isPrimaryKey: i === rowIndex ? true : false |
There was a problem hiding this comment.
This will limit having only one primary key at a time?
Do we have it by design?
There was a problem hiding this comment.
Nope. We don't have any design for it as of now. Do we need it? Like should I ask for it?
There was a problem hiding this comment.
We should not make this the default. The user should be free to choose multiple columns as the primary key if the database supports it.
There was a problem hiding this comment.
Semantics: I don't think there are any DB engines that support multiple Primary keys on a single table, it kind of defies the purpose (but I'm happy to be proven wrong).
However, you can have a composite primary key that consists out of multiple columns. So, lets first clarify what we want to achieve here
a) marking a simple column as primary key
b) also using the UI to create a composite primary key (which I think most engines support)
@JohanAhlen do you agree?
There was a problem hiding this comment.
Apologies, I also meant the composite primary key, where we select two or more columns to make a single primary key.
| title: 'fixed_name', | ||
| type: 'STRING', | ||
| comment: 'comment1', | ||
| isPrimaryKey: false |
There was a problem hiding this comment.
Add a test with assertions for the case where this is true.
What changes were proposed in this pull request?
Add Primary key column in bulk column modal.
How was this patch tested?
Manual testing. Updated unit tests. Find the video of the change made attached.
Screen.Recording.2025-10-27.at.3.51.14.PM.mov
Please review Hue Contributing Guide before opening a pull request.