Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Refactor CI workflows to separate the PR comment actions into a new workflow #4034

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

Harshg999
Copy link
Collaborator

@Harshg999 Harshg999 commented Mar 7, 2025

What changes were proposed in this pull request?

  • Refactor the CI workflows to separate the PR comments actions into a new workflow and only run for Python3.11
  • This will help us to mark these actions required or not, so that is does not block merging PRs when something is broken in them.
  • For example: If the PR is coming from a fork Hue repo, the PR comments actions fails because of insufficient permissions on the Github token. This is a good thing but it should not break the flow of other checks.

How was this patch tested?

  • Checking on PR Actions workflow runs

Copy link

github-actions bot commented Mar 7, 2025

⚠️ No unit test files modified. Please ensure that changes are properly tested. ⚠️

@Harshg999 Harshg999 self-assigned this Mar 7, 2025
@Harshg999 Harshg999 changed the title [ci] Refactor CI workflows to streamline pytest coverage reporting and add new PR comments workflow [ci] Refactor CI workflows to separate the PR comment actions into a new workflow Mar 7, 2025
Copy link

github-actions bot commented Mar 7, 2025

Backend Codecov

Backend Code Coverage Report •
FileStmtsMissCoverMissing
TOTAL533172613850% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1088 107 💤 0 ❌ 0 🔥 4m 53s ⏱️

@Harshg999 Harshg999 enabled auto-merge (squash) March 7, 2025 13:01
Copy link
Collaborator

@agl29 agl29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Harshg999 Harshg999 merged commit b5fc7fa into master Mar 7, 2025
7 of 8 checks passed
@Harshg999 Harshg999 deleted the final-ci-refactor branch March 7, 2025 13:12
athithyaaselvam pushed a commit that referenced this pull request Mar 11, 2025
…new workflow (#4034)

- Refactor the CI workflows to separate the PR comments actions into a new workflow and only run for Python3.11
- This will help us to mark these actions required or not, so that is does not block merging PRs when something is broken in them. 
- For example: If the PR is coming from a fork Hue repo, the PR comments actions fails because of insufficient permissions on the Github token. This is a good thing but it should not break the flow of other checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants