Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[api] Fix error handling in bulk operations #3990

Merged
merged 3 commits into from
Feb 12, 2025
Merged

[api] Fix error handling in bulk operations #3990

merged 3 commits into from
Feb 12, 2025

Conversation

Harshg999
Copy link
Collaborator

What changes were proposed in this pull request?

  • Error handling was broken for 500 code JsonResponse objects for the bulk operations. This PR fixes it and improves the error response structure a bit.
  • More improvement will be part of Error UX roadmap item.

How was this patch tested?

  • Manually

Copy link
Contributor

@JohanAhlen JohanAhlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tabraiz12 tabraiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do review the comment i have left.

@Harshg999 Harshg999 merged commit a6794a2 into master Feb 12, 2025
5 of 6 checks passed
@Harshg999 Harshg999 deleted the fix-move-same branch February 12, 2025 12:24
amitsrivastava pushed a commit that referenced this pull request Mar 10, 2025
(cherry picked from commit a6794a2)
(cherry picked from commit a03f11d75cb8f65f8332056194974c04c7c970f9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants