AWS VPC Endpoint Support #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmperro
force-pushed
the
aws-priv-endpoints
branch
from
21ee67c to
df88535
Compare
Chaffelson
approved these changes
Oct 20, 2021
Chaffelson
reviewed
Oct 20, 2021
wmudge
requested changes
Oct 29, 2021
| infra__aws_nat_gateway_name: "{{ infra.aws.vpc.nat_gateway.name | default([infra__namespace, infra__aws_nat_gateway_suffix] | join('-')) }}" | ||
| infra__aws_nat_gateway_suffix: "{{ infra.aws.vpc.nat_gateway.suffix | default(common__ngw_suffix) }}" | ||
|
|
||
| infra__aws_private_endpoints: "{{ infra.aws_private_endpoints | default(common__tunnel) }}" |
There was a problem hiding this comment.
Needs to be added to the docs/configuration.yml file
There was a problem hiding this comment.
Added. Also changed param to infra.aws.vpc.private_endpoints for better nesting.
| state: present | ||
| region: "{{ infra__region }}" | ||
| vpc_id: "{{ infra__aws_vpc_id }}" | ||
| tags: "{{ infra__tags | combine({ 'Name': 'vpce_sg' }, recursive=True) }}" |
There was a problem hiding this comment.
All SG's will have the same name? This should be linked to the NS at minimum
…lts to tunnel value - can be overridden. Signed-off-by: Chris Perro <cmperro@gmail.com>
…. Fix name tag for VPCE security group. Add items to config.yml Signed-off-by: Chris Perro <cmperro@gmail.com>
cmperro
force-pushed
the
aws-priv-endpoints
branch
from
55c3114 to
7c4f94b
Compare
wmudge
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cloudera.exe changes ONLY - No impact on cloudera.cloud and cdpy
This PR will: