Skip to content

Conversation

@chusopr
Copy link
Contributor

@chusopr chusopr commented Sep 13, 2023

That task requires privileges that may be restricted and it's used to set the plat__gcp_xaccount_keys variable which is only used during the teardown phase, so this PR moves this task to where it's used removing any additional permission that may be needed to run this task during deployments when it's not really needed.

This has been tested by doing full deployment + teardown of a cluster (infra + plat + run).

@chusopr chusopr force-pushed the xaccount-list-teardown branch from 09fc486 to 95913bf Compare September 13, 2023 11:36
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Sep 13, 2023
@wmudge wmudge added this to the Release 2.1.0 milestone Oct 5, 2023
@wmudge wmudge modified the milestones: Release 2.1.0, Release 2.2.0 Nov 2, 2023
@wmudge wmudge modified the milestones: Release 2.2.0, Release 2.3.0 Nov 20, 2023
@jimright jimright self-assigned this Dec 20, 2023
@wmudge wmudge requested a review from a team December 20, 2023 16:43
@jimright jimright added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Dec 20, 2023
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chusopr. I've tested a full setup and teardown similar to how you describe and all works well. Approved.

That task requires privileges that may be restricted and it's only used during the teardown phase.

Signed-off-by: Jesus Perez Rey <jprey@bluemetrix.com>
@chusopr chusopr force-pushed the xaccount-list-teardown branch from 95913bf to 8d105d7 Compare December 21, 2023 15:33
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Dec 21, 2023
@wmudge wmudge merged commit 275d52d into cloudera-labs:devel Dec 21, 2023
wmudge added a commit to wmudge/cloudera.exe that referenced this pull request Aug 12, 2025
* Add Galaxy import test
* Add missing authors (cannot be empty)
* Update deprecated actions
* Add Galaxy import workflow on release publication

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG validated The pull request has passed the prechecks

Development

Successfully merging this pull request may close these issues.

3 participants