Skip to content

Change 'tls' parameter to 'auto_tls' #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2025
Merged

Change 'tls' parameter to 'auto_tls' #285

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192ec88
Change 'tls' parameter to 'auto_tls' due to collision with existing T…
wmudge May 15, 2025
67e5d50
Update API documentation for Auto-TLS parameter
wmudge May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions plugins/modules/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,7 @@
required: no
aliases:
- data_contexts
tls:
auto_tls:
description:
- Flag enabling TLS for the cluster.
type: bool
Expand Down Expand Up @@ -838,7 +838,7 @@ def __init__(self, module):
self.contexts = self.get_param("contexts")
self.auto_assign = self.get_param("auto_assign")
self.control_plane = self.get_param("control_plane")
self.tls = self.get_param("tls")
self.auto_tls = self.get_param("auto_tls")
self.force = self.get_param("force")

self.changed = False
Expand Down Expand Up @@ -926,8 +926,8 @@ def process(self):
self.create_cluster_from_parameters()

# Toggle AutoTLS
if self.tls is not None:
if self.tls:
if self.auto_tls is not None:
if self.auto_tls:
enable_tls_cmd = (
self.cluster_api.configure_auto_tls_services_command(
cluster_name=self.name
Expand Down Expand Up @@ -973,8 +973,8 @@ def process(self):
self.create_cluster_from_parameters()

# Toggle AutoTLS
if self.tls is not None:
if self.tls:
if self.auto_tls is not None:
if self.auto_tls:
enable_tls_cmd = (
self.cluster_api.configure_auto_tls_services_command(
cluster_name=self.name
Expand Down Expand Up @@ -1023,8 +1023,8 @@ def process(self):
self.create_cluster_from_parameters()

# Toggle AutoTLS
if self.tls is not None:
if self.tls:
if self.auto_tls is not None:
if self.auto_tls:
enable_tls_cmd = (
self.cluster_api.configure_auto_tls_services_command(
cluster_name=self.name
Expand All @@ -1045,8 +1045,8 @@ def process(self):
else:
self.changed = True
# Toggle AutoTLS
if self.tls is not None:
if self.tls:
if self.auto_tls is not None:
if self.auto_tls:
enable_tls_cmd = (
self.cluster_api.configure_auto_tls_services_command(
cluster_name=self.name
Expand Down Expand Up @@ -1081,8 +1081,8 @@ def process(self):
self.create_cluster_from_parameters()

# Toggle AutoTLS
if self.tls is not None:
if self.tls:
if self.auto_tls is not None:
if self.auto_tls:
enable_tls_cmd = (
self.cluster_api.configure_auto_tls_services_command(
cluster_name=self.name
Expand Down Expand Up @@ -1687,7 +1687,7 @@ def main():
# Optional data contexts, required for compute-type clusters
contexts=dict(type="list", elements="str", aliases=["data_contexts"]),
# Optional enable/disable TLS for the cluster
tls=dict(type="bool", aliases=["tls_enabled", "cluster_tls"]),
auto_tls=dict(type="bool", aliases=["tls_enabled", "cluster_tls"]),
# Optional force first run services initialization
force=dict(type="bool", aliases=["forced_init"]),
# Optional auto-assign roles on cluster (honors existing assignments)
Expand Down
Loading