Skip to content

Add lookup plugins for DL and DH #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jun 7, 2023
Merged

Add lookup plugins for DL and DH #98

merged 7 commits into from
Jun 7, 2023

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented May 22, 2023

Address common tasks when constructing with a DL or DH service

wmudge added 6 commits May 22, 2023 12:45
@wmudge
Add parse_environment, move parse_services (removing CdpServiceLookup…
b114ac5 
…Module)

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Convert to use parse_services directly
e9e1afe 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Create datahub_definition lookup
39e7392 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Create datahub_template lookup
bf9b00e 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Create datahub_instance lookup
84ef1c5 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Create datalake_runtime lookup
6259363 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label May 22, 2023
@wmudge wmudge requested a review from a team May 22, 2023 16:49
@github-actions github-actions bot added the validated The pull request has passed the prechecks label May 22, 2023
rsuplina
rsuplina reviewed May 23, 2023
View reviewed changes
Copy link
Contributor

@rsuplina rsuplina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wmudge
Add note for OSX error
f5eb0dd 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels May 23, 2023
jimright
jimright approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit 26ee4c8 into cloudera-labs:devel Jun 7, 2023
@wmudge wmudge deleted the feature/service_template_definition_lookups branch June 7, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rsuplina rsuplina rsuplina left review comments

@jimright jimright jimright approved these changes

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG validated The pull request has passed the prechecks

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wmudge @jimright @rsuplina