Start an environment without starting the datahubs within it #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimright
requested changes
Oct 24, 2022
There was a problem hiding this comment.
@chusopr - apart from the missing note about the argument in the DOCUMENTATION this looks good.
Here is how I tested it:
- Start no arguments. ENV + DH started as expected. ✔️
- Start with datahub_start True. ENV + DH started as expected. ✔️
- Start with datahub_start False. ENV started; DH stay stopped. ✔️
- Create and teardown of environment. Both worked as expected. ✔️
…ted` state support starting an environment without starting the datahubs within it. Signed-off-by: Jesus Perez Rey <jprey@bluemetrix.com>
chusopr
force-pushed
the
start_env-without_datahubs
branch
from
1280746 to
ffb32a8
Compare
jimright
approved these changes
Nov 4, 2022
wmudge
approved these changes
Nov 7, 2022
wmudge
pushed a commit
to wmudge/cloudera.cloud
that referenced
this pull request
Feb 1, 2023
* Add 'datahub_start' option to switch an environment to the `started` state to support starting an environment without starting the datahubs within it. Signed-off-by: Jesus Perez Rey <jprey@bluemetrix.com> Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
datahub_startoption when switching an environment to thestartedstate support starting an environment without starting the datahubs within it.It's set to True by default to be consistent with the current behaviour without requiring modifications in current code using this module.
Tested on CDP Public Cloud on GCP.
It requires cloudera-labs/cdpy#57