Fix for CDW Virtual Warehouse race condition #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmudge
requested changes
Oct 5, 2022
| - "Chris Perro (@cmperro)" | ||
| - "Webster Mudge (@wmudge)" | ||
| - "Dan Chaffelson (@chaffelson)" | ||
| - "Chris Perro (@cmperro)" |
There was a problem hiding this comment.
I cleared the commits that contained this from the PR, they shouldn't have been there anyway.
Fixes cloudera-labs#74 by adding Stopped states as valid deployment completion states for CDW Virtual Warehouses as they may idle-stop before other deployments complete Fixed other minor formatting warnings in dw_virtual_warehouse.py Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com>
Chaffelson
force-pushed
the
fix_cdw_vw_rc
branch
from
0581dc9 to
0b08e90
Compare
wmudge
approved these changes
Nov 7, 2022
wmudge
pushed a commit
to wmudge/cloudera.cloud
that referenced
this pull request
Feb 1, 2023
* Fix cloudera-labs#74 by adding 'stopped' states as valid deployment completion states for CDW Virtual Warehouses as they may idle-stop before other deployments complete * Fix other minor formatting warnings in dw_virtual_warehouse.py Signed-off-by: Daniel Chaffelson <chaffelson@gmail.com> Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74 by adding Stopped states as valid deployment completion states for CDW Virtual Warehouses as they may idle-stop before other deployments complete
Fixed other minor formatting warnings in dw_virtual_warehouse.py
Correct module name in cloudera.cloud.datahub_cluster