Skip to content

Add parameter for control plane region #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add parameter for control plane region #73

wants to merge 2 commits into from

Conversation

@airosa
Copy link
Contributor

@airosa airosa commented Sep 22, 2022

With this patch we managed to successfully create an environment in the EU control plane.

  • used the same name (cp_region) as in cdpy
  • set the default cp_region to "default" which seemed to be the default in cdpy
  • made no changes to documentation

@airosa
Copy link
Contributor Author

airosa commented Oct 10, 2022

Just an update - we are ready to provision our next environment in the EU Control Plane. It would be fantastic if we did not have to use our patched version of cloudera.cloud. Please let me know if you need any input on this PR.

@wmudge wmudge requested review from Chaffelson and wmudge November 7, 2022 19:52
@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Nov 7, 2022
@wmudge wmudge changed the base branch from main to devel November 7, 2022 19:52
@wmudge
Copy link
Member

wmudge commented Nov 7, 2022

Hello @airosa - could you please sign your commits and push again? (The DCO bot points to instructions on how to do this. Let me know if you have any questions.)

Thanks!

@wmudge
Copy link
Member

wmudge commented Nov 7, 2022

Looks good, but needs documentation in the cdp_sdk_options.py file in plugins/doc_fragments.

wmudge
wmudge requested changes Nov 9, 2022
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO and doc_fragments

@wmudge wmudge added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 6, 2023
@wmudge wmudge removed the request for review from Chaffelson October 5, 2023 16:52
@wmudge wmudge added this to the Release 2.1.0 milestone Oct 5, 2023
@wmudge wmudge modified the milestones: Release 2.1.0, Release 2.2.0 Nov 2, 2023
@wmudge wmudge modified the milestones: Release 2.2.0, Release 2.3.0 Nov 20, 2023
@wmudge wmudge self-assigned this Dec 20, 2023
@wmudge wmudge mentioned this pull request Dec 21, 2023
Merged
@wmudge
Copy link
Member

wmudge commented Dec 21, 2023

Updated in #136 -- thanks for this original!

@wmudge wmudge closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge requested changes

Assignees

@wmudge wmudge

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG good first issue Good for newcomers help wanted Extra attention is needed

Milestone

Release 2.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@airosa @wmudge