Skip to content

Subnet filters for the DF service #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 6, 2023
Merged

Subnet filters for the DF service #64

merged 6 commits into from
Mar 6, 2023

Conversation

@asdaraujo
Copy link
Contributor

Fixed some issues that existed in the original df_service module.
Added subnet filter options to allow for more flexibility when enabling the service.

@asdaraujo asdaraujo requested review from Chaffelson and wmudge July 7, 2022 04:56
@asdaraujo asdaraujo mentioned this pull request Jul 7, 2022
Merged
@Chaffelson
Copy link
Contributor

LGTM.
@wmudge what do you think about introducing a jmespath filter option? Neatly solves the lazy evaluation problem

wmudge
wmudge requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add jmespath to the requirements.

@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Jul 14, 2022
@wmudge wmudge self-requested a review November 7, 2022 19:52
@asdaraujo
Copy link
Contributor Author

Any updates on this?

Chaffelson
Chaffelson suggested changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@Chaffelson Chaffelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, I would prefer that the function to apply the jmes path is refactored into the common utilities package however.

@asdaraujo
Fixed reference to an inexistent attribute in error message formatting.
d0fe4e6 
And shortened a few other message lines.

Signed-off-by: Andre Araujo <araujo@cloudera.com>
@asdaraujo
The loadbalancer_subnets parameter was being ignored.
a7c5f4b 
Due to being extracted with the wrong name (lb_subnets)

Signed-off-by: Andre Araujo <araujo@cloudera.com>
@asdaraujo
Fixed inaccuracies and missing parts in the module doc.
4dfad2f 
Signed-off-by: Andre Araujo <araujo@cloudera.com>
@asdaraujo
Added cluster_subnets_filter and loadbalancer_subnets_filter options …
7b1c9e7 
…to module.

Signed-off-by: Andre Araujo <araujo@cloudera.com>
@asdaraujo
Added a subnet filter parameter to DataHub Cluster.
03f3bdb 
Signed-off-by: Andre Araujo <araujo@cloudera.com>
@asdaraujo
Removed non-boolean required references in doc.
2af8d37 
Signed-off-by: Andre Araujo <araujo@cloudera.com>
@asdaraujo asdaraujo requested a review from Chaffelson January 4, 2023 00:36
@wmudge wmudge removed the request for review from Chaffelson March 6, 2023 21:42
@wmudge wmudge merged commit 363ad89 into cloudera-labs:devel Mar 6, 2023
@asdaraujo asdaraujo deleted the df-service-filters branch June 21, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge approved these changes

+1 more reviewer

@Chaffelson Chaffelson Chaffelson requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asdaraujo @Chaffelson @wmudge