Fix freeipa parameter for env module #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Includes an initial take on unit testing via |
|
While I really want to introduce the test components, is it appropriate to add it to a hotfix? @wmudge |
|
I'll split into two PRs |
wmudge
force-pushed
the
hotfix/env_freeipa_defaults
branch
from
b967971 to
8650eb4
Compare
|
@Chaffelson - isolated this PR to just the fix and pushed the test harness to #65 |
wmudge
force-pushed
the
hotfix/env_freeipa_defaults
branch
from
8650eb4 to
eab20b8
Compare
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
wmudge
force-pushed
the
hotfix/env_freeipa_defaults
branch
from
eab20b8 to
6109fa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
freeipaparameter is no longer optional in the endpoint. Adding a default ofinstanceCountByGroup=2, i.e. LIGHT_DUTY, to theenvmodule.