Skip to content

Conversation

@nmarian85
Copy link
Contributor

Somehow the DCO signed commits are giving me headaches. Retrying.

Signed-off-by: Nicolaie Marian <nmarian85@gmail.com>
Signed-off-by: Nicolaie Marian <nmarian85@gmail.com>
Signed-off-by: Nicolaie Marian <nmarian85@gmail.com>
@nmarian85
Copy link
Contributor Author

Wow, it worked :). Took me a moment to realize that the Author name and Signed-off-by field need to be the same. Github should document that feature better.

@wmudge wmudge changed the base branch from main to devel March 9, 2022 17:19
- polling_timeout
raz:
description:
- Flag indicating if Ranger RAZ fine grained access should be enabled for the datalake
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also should add entry for the response, which now includes enableRangerRaz

payload.update(scale=self.scale)

if self.raz:
payload.update(enableRangerRaz=self.raz)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not supported yet in GCP last time I checked, so will need a guard condition

Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a guard condition for GCP deployments and update the general response fields to include the RAZ entry

@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Mar 31, 2022
@wmudge
Copy link
Member

wmudge commented Jul 21, 2022

Handled by #55

@wmudge wmudge closed this Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG

Development

Successfully merging this pull request may close these issues.

2 participants