Skip to content

Add and update CDW modules #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 16, 2021
Merged

Add and update CDW modules #29

merged 23 commits into from
Sep 16, 2021

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented Aug 19, 2021

@wmudge wmudge requested review from Chaffelson and cmperro August 19, 2021 21:10
@wmudge wmudge mentioned this pull request Aug 19, 2021
Open
@wmudge
Copy link
Member Author

wmudge commented Aug 19, 2021

Either we commit this one or #19 - but not both!

@wmudge wmudge mentioned this pull request Aug 20, 2021
Closed
@wmudge
Copy link
Member Author

wmudge commented Aug 20, 2021

Note that the details returned by cloudera.cloud.dw_cluster_info no longer calls cdpy.gather_clusters as this call has different values depending on whether or not you pass in env. In addition, that call is out-of-scope for the module.

Chaffelson
Chaffelson suggested changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@Chaffelson Chaffelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly the use of bare id ambiguously across the modules

raju-saravanan and others added 23 commits September 16, 2021 09:14
@raju-saravanan @wmudge
Support CDW DBC and VW creation
69ca9df 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Fix class docs
9202f72 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Make vw and dbc modules idempotent
9a5dae2 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Make the dbc and vw module idempotent
92d8568 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Use started state in wait for state function
9e82a70 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Fix typo
0edfa73 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Rename vh and dbc module
afbcde7 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@raju-saravanan @wmudge
Expand common_config and application_config
babd10e 
Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
@wmudge
Update module documentation, return values, and logic flow
29b0014 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
WIP of documentation updates, return values and logic flow
81e8424 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add modules to documentation
1a4409e 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add missing descriptions to ConfigBlocks
5c19a60 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Tweak fail message
3fdcfd8 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update module spec, API doc, and adjust logic flow for singular retur…
1df347f 
…n value

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add dw_database_catalog_info module
f2de47f 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Fix debug log bug
c29f82e 
Issue violations as discrete array in returned error
Add check for verbosity or debug to SDK warnings handler

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update log messaging
5f2a37c 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update module variable requirements
eff634f 
Update deletion states and process
Update log messaging

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update deletion states and process
68a96ba 
Update module parameter requirements
Update log messaging

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Refactor scope to only return cluster details
73dbad4 
Remove 'name' parameter
Refactor remaining parameters for aliases and requirements

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Add dw_virtual_warehouse_info module
e4a9404 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Update parameter naming, aliases, and requirements
02749f8 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge
Clarify parameter names and aliases for DW modules
1302819 
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge requested a review from Chaffelson September 16, 2021 16:17
@wmudge wmudge force-pushed the wmudge/feature/cdw-level-2 branch from 34fc07a to 1302819 Compare September 16, 2021 16:31
@wmudge wmudge merged commit bac4fe3 into cloudera-labs:devel Sep 16, 2021
acsjumpi pushed a commit to acsjumpi/cloudera.cloud that referenced this pull request Sep 28, 2021
@wmudge @raju-saravanan @acsjumpi
Add and update CDW modules (cloudera-labs#29)
7995a8c 
* Add 'dw_database_catalog' and 'dw_database_catalog_info' modules
* Add 'dw_virtual_warehouse' and 'dw_virtual_warehouse_info' modules
* Update 'dw_cluster' and 'dw_cluster_info' modules documentation
* Normalize top-level key for return values from 'clusters' to 'cluster' for 'dw_cluster'
* Add 'private_load_balancer' option to 'dw_cluster' module
* Replace 'cdpy.dw.gather_clusters()' call with 'cdpy.dw.list_clusters()' call in 'dw_cluster_info' module to reduce scope of returned values (will require explicit 'dw_*_info' calls to achieve prior returned values)
* Add 'violations' as discrete key within returned SDK errors
* Add check for verbosity or debug to SDK warnings handler
* Update parameter naming, aliases, and requirements across all 'dw_*' modules

Signed-off-by: Saravanan Raju <saravanan.footloose@gmail.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Co-authored-by: Saravanan Raju <saravanan.footloose@gmail.com>
Signed-off-by: Alan <alan.silva@cloudera.com>
@wmudge wmudge mentioned this pull request Oct 6, 2021
Closed
@wmudge wmudge added the enhancement MINOR - New feature or enhancement in the CHANGELOG label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmperro cmperro Awaiting requested review from cmperro

@Chaffelson Chaffelson Awaiting requested review from Chaffelson

Assignees

No one assigned

Labels

enhancement MINOR - New feature or enhancement in the CHANGELOG

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wmudge @Chaffelson @raju-saravanan