- 
                Notifications
    You must be signed in to change notification settings 
- Fork 28
Configure documentation toolchain with antsibull-docs #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    c3b3515    to
    9c8692d      
    Compare
  
    9c8692d    to
    740fd16      
    Compare
  
    740fd16    to
    851f1f0      
    Compare
  
    851f1f0    to
    170c69e      
    Compare
  
    170c69e    to
    872908a      
    Compare
  
    2d2ee5d    to
    1d18b40      
    Compare
  
    
              
                    jimright
  
              
              requested changes
              
                  
                    Sep 27, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good. Just had 2 questions about the details exposed in the integration tests.
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
…ection Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
cccd13e    to
    ef7d10c      
    Compare
  
    Signed-off-by: Webster Mudge <wmudge@cloudera.com>
              
                    jimright
  
              
              approved these changes
              
                  
                    Sep 27, 2023 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Approved.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    documentation
  Improvements or additions to documentation 
  
    enhancement
  MINOR - New feature or enhancement in the CHANGELOG 
  
    validated
  The pull request has passed the prechecks 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Update the collection to build API docs on both pushes to
mainbut also viadispatch.