Skip to content

Conversation

@wmudge
Copy link
Member

@wmudge wmudge commented Sep 15, 2023

Update the collection to build API docs on both pushes to main but also via dispatch.

@wmudge wmudge added documentation Improvements or additions to documentation enhancement MINOR - New feature or enhancement in the CHANGELOG labels Sep 15, 2023
@wmudge wmudge requested a review from a team September 15, 2023 15:14
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 15, 2023
@wmudge wmudge force-pushed the update/antsibull-docs branch from c3b3515 to 9c8692d Compare September 15, 2023 21:13
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 15, 2023
@wmudge wmudge force-pushed the update/antsibull-docs branch from 9c8692d to 740fd16 Compare September 15, 2023 21:24
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 15, 2023
@wmudge wmudge force-pushed the update/antsibull-docs branch from 740fd16 to 851f1f0 Compare September 15, 2023 21:54
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 15, 2023
@wmudge wmudge force-pushed the update/antsibull-docs branch from 851f1f0 to 170c69e Compare September 15, 2023 23:15
@github-actions github-actions bot removed the validated The pull request has passed the prechecks label Sep 15, 2023
@wmudge wmudge force-pushed the update/antsibull-docs branch from 170c69e to 872908a Compare September 15, 2023 23:16
@github-actions github-actions bot added the validated The pull request has passed the prechecks label Sep 15, 2023
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 18, 2023
@wmudge wmudge force-pushed the update/antsibull-docs branch from 2d2ee5d to 1d18b40 Compare September 18, 2023 17:57
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 18, 2023
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 27, 2023
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general this looks good. Just had 2 questions about the details exposed in the integration tests.

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
…ection

Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@wmudge wmudge force-pushed the update/antsibull-docs branch from cccd13e to ef7d10c Compare September 27, 2023 15:57
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 27, 2023
Signed-off-by: Webster Mudge <wmudge@cloudera.com>
@github-actions github-actions bot added validated The pull request has passed the prechecks and removed validated The pull request has passed the prechecks labels Sep 27, 2023
Copy link
Contributor

@jimright jimright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Approved.

@wmudge wmudge merged commit 95bd084 into cloudera-labs:devel Sep 27, 2023
@wmudge wmudge deleted the update/antsibull-docs branch September 27, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement MINOR - New feature or enhancement in the CHANGELOG validated The pull request has passed the prechecks

Development

Successfully merging this pull request may close these issues.

2 participants