This repository was archived by the owner on Jun 30, 2023. It is now read-only.
Inline Files.write() in GenApiConfigAction#175
Merged
gunsch merged 1 commit intocloudendpoints:masterfrom Dec 3, 2018
nick-someone:patch-1
Merged
Inline Files.write() in GenApiConfigAction#175gunsch merged 1 commit intocloudendpoints:masterfrom nick-someone:patch-1
gunsch merged 1 commit intocloudendpoints:masterfrom
nick-someone:patch-1
Conversation
Files.write is deprecated and scheduled for removal. Changing this to use Files.asCharSink().write() is the same implementation, but is not deprecated.
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage 80.06% 80.06%
Complexity 1715 1715
=========================================
Files 159 159
Lines 5718 5718
Branches 754 754
=========================================
Hits 4578 4578
Misses 856 856
Partials 284 284
Continue to review full report at Codecov.
|
gunsch-google
approved these changes
Dec 3, 2018
gunsch
approved these changes
Dec 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Files.write is deprecated and scheduled for removal. Changing this to use Files.asCharSink().write() is the same implementation, but is not deprecated.