Skip to content

Migrate pull requests #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2022
Merged

Migrate pull requests #156

merged 2 commits into from
Jan 30, 2022

Conversation

torenken
Copy link

Migration of cdk-pull-request-check and cdk-pull-request-approval-rule to cdkv2.

Changes:

  • Change to Node14 in the Lambda functions and LinuxBuildImage Standard 5.
  • As discussion, I use aws-cdk-lib/assertions for pull-request-check tests

@hupe1980
Copy link
Member

@torenken Can you please use cdk2 as the target branch.

@torenken torenken changed the base branch from master to cdk2 January 29, 2022 11:45
hupe1980
hupe1980 approved these changes Jan 30, 2022
View reviewed changes
Copy link
Member

@hupe1980 hupe1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thx

@hupe1980 hupe1980 linked an issue Jan 30, 2022 that may be closed by this pull request
Upgrade to aws cdk v2 #142
Closed
@hupe1980 hupe1980 merged commit 3ac4518 into cloudcomponents:cdk2 Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hupe1980 hupe1980 hupe1980 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade to aws cdk v2
2 participants
@torenken @hupe1980