Skip to content

LITE-29138 Fix product clone translation #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2023
Merged

LITE-29138 Fix product clone translation #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connect/cli/plugins/shared/translation_attr_sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ def _collect_attributes_to_update(self, ws, translation, is_clone):
new_attrs = None
if is_clone and translation is not None:
translation_res = self._client.ns('localization').translations[translation['id']]
new_attrs = translation_res.attributes.all()
new_attrs = list(translation_res.attributes.all())
attributes = {}
for row_idx, row in enumerate(ws.iter_rows(min_row=2, values_only=True), 2):
row = AttributeRow(*row)
Expand Down