Bail if we fail to cleanup failed instance #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if we fail to cleanup failed instance, we return before retrying to recreate it. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
fix-instance-retry
branch
from
226ba0a to
7730799
Compare
Contributor
|
.. what also could be a related problem is that the whole 'create new runners' and 'delete old runners' process takes longer than the time ticker. This could cause work to pile up.. but I haven't check to code if this is a problem or not. |
Member
Author
In theory, it should be fine. When we create a new instance we transition from |
maigl
reviewed
Feb 7, 2023
Co-authored-by: Michael Kuhnt <maigl@users.noreply.github.com>
gabriel-samfira
force-pushed
the
fix-instance-retry
branch
from
dd826c6 to
439eeee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to cleanup failed instance, we return before retrying to recreate it.
Fixes: #76
Signed-off-by: Gabriel Adrian Samfira gsamfira@cloudbasesolutions.com