Add the ability to set tools download source (Gitea) #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabriel-samfira
force-pushed
the
allow-static-tools
branch
from
792ff18 to
31b986b
Compare
This change adds 2 new options to gitea forge endpoints: * Tools metadata URL * Use internal tools URLs By default, GARM looks in the releases page of the gitea arc_runner to determine where it can download the runner binary from for a particular OS/arch. The tools metadata URL option can be set on an endpoint and can point to a mirror of the upstream repo. The requirement is that the asset names exactly mirror upstream naming conventions. The second option disables GARM calling out to the tools metadata URL entirely. GARM has some hardcoded values for nightly binaries. If this option is checked, GARM will use those values, without making any kind of outgoing API call to determine availability. This is useful in air-gapped environments. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
allow-static-tools
branch
from
31b986b to
55671f2
Compare
bachorp
reviewed
Sep 29, 2025
Comment on lines
+184
to
+193
| if err != nil { | ||
| slog.ErrorContext(ctx, "failed to get tools from metadata URL", "error", err) | ||
| if metadataURL != appdefaults.GiteaRunnerReleasesURL { | ||
| slog.InfoContext(ctx, "attempting to get tools from default upstream", "tools_url", appdefaults.GiteaRunnerReleasesURL) | ||
| latest, err = getReleasesFromURL(ctx, metadataURL) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("failed to get upstream tools: %w", err) | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
There is a bug. err is not returned if metadataURL == appdefaults.GiteaRunnerReleasesURL .
Member
Author
There was a problem hiding this comment.
nightly image is building with the above mentioned patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds 2 new options to gitea forge endpoints:
By default, GARM looks in the releases page of the gitea act_runner to determine where it can download the runner binary from for a particular OS/arch. The tools metadata URL option can be set on an endpoint and can point to a mirror of the upstream repo. The requirement is that the asset names exactly mirror upstream naming conventions.
You can create a mirror of the upstream act_runner repo using a script such as this: https://gist.github.com/gabriel-samfira/006ecd5802dbb25e70348601a776c369
The second option disables GARM calling out to the tools metadata URL entirely. GARM has some hardcoded values for nightly binaries. If this option is checked, GARM will use those values, without making any kind of outgoing API call to determine availability. This is useful in air-gapped environments.
In the UI, the update modal now includes both options:
The CLI now has 2 new options when adding and updating the endpoints:
Fixes: #536