Add GitHub Enterprise support #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2022
gabriel-samfira
force-pushed
the
add-ghe-server-support
branch
from
4bffd5f to
ed08def
Compare
gabriel-samfira
force-pushed
the
add-ghe-server-support
branch
3 times, most recently
from
42e36ce to
5be295b
Compare
The GitHub credentials section now allows setting some API endpoints that point the github client and the runner setup script to the propper URLs. This allows us to use garm with an on-prem github enterprise server. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
This change adds enterprise support throughout garm. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Garm no longer fails on startup if a pool manager cannot be started. It will attempt to start the pool manager in the background. If it fails due to an unauthorized error, it will sleep for 3 hours. It is unlikely it will work a second time if credentials are not updated in the config and garm is restarted, so no point in getting rate limited. Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
gabriel-samfira
force-pushed
the
add-ghe-server-support
branch
from
5be295b to
f13d63b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the following:
garmwith your own deployment of GitHub Enterprise serverThe
[[github]]section now allows you to specify API endpoint information, as well as a CA certificate bundle to validate the server certificate. The new config options are optional. Leaving them blank will default to github.com.New API endpoints have been added to
garmthat allow you to create enterprise level pools. The garm CLI has also been updated to add enterprise support.From a garm UX perspective, enterprises are set up identically to organizations.
Note: This PR adds a
replacedirective ingo.modto a local fork of thego-githubpackage, because the upstream library doesn't support querying the enterprise level runner applications downloads. The replace directive will be removed when that functionality is added upstream.These changes have only been tested with the
LXDprovider. Theexternalproviders will be updated shortly to account for the CA certificate bundle and download token.Docs will be updated with examples, shortly.
Fixes: #30
Fixes: #44