Skip to content

Check for nil pointer before dereferencing #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabriel-samfira merged 1 commit into from
Mar 26, 2024
Merged

Check for nil pointer before dereferencing #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions cmd/garm-cli/cmd/log.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,16 @@ var logCmd = &cobra.Command{
if err != nil {
var resp apiParams.APIErrorResponse
var msg string
if err := json.NewDecoder(response.Body).Decode(&resp); err == nil {
msg = resp.Details
var status string
if response != nil {
if response.Body != nil {
if err := json.NewDecoder(response.Body).Decode(&resp); err == nil {
msg = resp.Details
}
}
status = response.Status
}
log.Fatalf("failed to stream logs: %s (%s)", msg, response.Status)
log.Fatalf("failed to stream logs: %q %s (%s)", err, msg, status)
}
defer c.Close()

Expand Down