Skip to content

Conversation

@mihaelabalutoiu
Copy link
Member

@mihaelabalutoiu mihaelabalutoiu commented Aug 7, 2023

  • This PR implements cleanup of the orphan runners for org/repo.
  • I updated the PR with the following changes:
    • I replaced the log.Fatalf with panic to prevent the exit 1 from interrupting the defer statement.
    • I put graceful cleanup functions in a function called GracefulCleanup and deferred it first.
    • Make sure that the graceful cleanup functions are idempotent.
    • I also added two functions: (GhOrgRunnersCleanup and GhRepoRunnersCleanup) to forcefully delete the runners via GitHub API and deferred them after the GracefulCleanup function.

Signed-off-by: Mihaela Balutoiu <mbalutoiu@cloudbasesolutions.com>
@gabriel-samfira gabriel-samfira merged commit 63d2764 into cloudbase:main Aug 9, 2023
@mihaelabalutoiu mihaelabalutoiu deleted the add-cleanup-runners branch August 9, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants