Skip to content

Conversation

@maigl
Copy link
Contributor

@maigl maigl commented Apr 19, 2023

This adds a config toggle to disable any package install or updates during boot / cloud-init.

This PR belongs to cloudbase/garm#84

Remarks:

I'm no really happy to duplicate this entire function just to add this if.

Michael Kuhnt michael.kuhnt@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)

@maigl maigl marked this pull request as ready for review April 19, 2023 08:37
@gabriel-samfira
Copy link
Member

Yeah, you are right. In the future, I think we should make this part a bit more granular to allow easy customization. For now, I think the easiest and quickest thing to do is add an extra param to GetCloudConfig() function in garm itself that disables updates. This way we don't have to copy it just for this.

Feel free to create a PR in garm that adds the flag. We can vendor it here and make use of it.

@maigl
Copy link
Contributor Author

maigl commented Apr 19, 2023

For now, I think the easiest and quickest thing to do is add an extra param to GetCloudConfig() function

.. or maybe we could add a new field UserDataOptions to the BootstrapInstance struct? This could be the first step towards more customization..

see cloudbase/garm#87

@maigl maigl force-pushed the disable-updates branch from dfb6699 to 15059fc Compare April 19, 2023 09:49
@gabriel-samfira
Copy link
Member

If you remove the replace and update to the latest commit of garm, we can merge this one too

@maigl
Copy link
Contributor Author

maigl commented Apr 19, 2023

If you remove the replace and update to the latest commit of garm, we can merge this one too

done

@gabriel-samfira gabriel-samfira merged commit 603a01c into cloudbase:main Apr 19, 2023
@gabriel-samfira
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants