Add custom operation options support #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some operations, such as creating a NIC team, custom operation options must be passed. This change exposes this functionality. Some methods now accept a 'operation_options' dict that may contain a field 'custom_options'. This needs to be a list of options, defined as dicts containing the option name, option value and a MI value type, allowing the option value to be 'casted' to a MI type. A sample provided by this patch brings a better overview of this feature. Note that operation_timeouts are now specified within the operation_options dict. The existing functional tests were updated to reflect this change. Also, one of the tests that was failing due to an expected timeout not being hit was fixed as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some operations, such as creating a NIC team, custom operation
options must be passed.
This change exposes this functionality. Some methods now accept
a 'operation_options' dict that may contain a field 'custom_options'.
This needs to be a list of options, defined as dicts containing the
option name, option value and a MI value type, allowing the option
value to be 'casted' to a MI type.
A sample provided by this patch brings a better overview of this
feature.
Note that operation_timeouts are now specified within the
operation_options dict. The existing functional tests were updated
to reflect this change. Also, one of the tests that was failing
due to an expected timeout not being hit was fixed as well.