This repository has been archived by the owner on Mar 6, 2023. It is now read-only.
tasks/preflight.yml: fixed systemd version fact parsing #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Newer versions of systemd used by Debian 10 or Fedora 30 report its version as three values, eg. "systemd 241 (v241-12.git1e19bcd.fc30)". Currently preflight task assumes that it has only two and use last one. However that value can't be converted to integer when templating systemd service. Thats causes icmp probe failure with the message msg="Error listening to socket" err="listen ip4:icmp 0.0.0.0: socket: operation not permitted". Parsing was modified to get second value from version string
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer versions of systemd used by Debian 10 or Fedora 30 report its
version as three values, eg. "systemd 241 (v241-12.git1e19bcd.fc30)".
Currently preflight task assumes that it has only two and use last
one. However that value can't be converted to integer when templating
systemd service. Thats causes icmp probe failure with the message
msg="Error listening to socket" err="listen ip4:icmp 0.0.0.0: socket:
operation not permitted".
Parsing was modified to get second value from version string