refactor for more canonical Julia code#56
Open
jbytecode wants to merge 2 commits intocloud-oak:masterfrom
Open
refactor for more canonical Julia code#56jbytecode wants to merge 2 commits intocloud-oak:masterfrom
jbytecode wants to merge 2 commits intocloud-oak:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all, thank you for developing such a library, indeed I used and I love it.
Here is my effort for a more canonical Julia codebase.
This pull request includes some changes in these categories:
const.== nothingconditions changed toisnothing()== 0conditions changed toiszero()for _ in iterator.function newline_to_spaces(string, terminal_width)is changed tofunction newline_to_spaces(st, terminal_width)just becausestringis a valid identifier of a function. This might cause confusion.==""type conditions replaced byisempty()update()function renamed toupdate!()because it mutates its input.All the tests are passed and it seems the changes don't affect the output but the code is more canonical with the new changes (and possibly a little bit faster with a more type stable code, const etc.).
Please do not hesitate to ignore my changes if it does not fit your needs.
Thank you in advance.