Issue/7/scheduler calls #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comment as made on the other PR ;-) "Can you rebase off of master (e.g., |
Implemented missing scheduler calls. Removed clojure.string library require, was not used.
The request api endpoint is not a 1 to 1 name match for type and payload keyword. (it is plural) New helper function to determine the payload keyword due to this endpoint name mismatch.
Renamed the helper function payload-kw to payload-key.
wdhowe
force-pushed
the
issue/7/scheduler-calls
branch
from
1ee7fc2 to
3ed8b38
Compare
|
Rebased on master. |
|
So I can't tell you how cool it is to see love being given to this project 😄 This was entirely a prototype/proof-of-concept effort (albeit with big aspirations). This is really wonderful to see ❤️ |
|
Awesome - We'll see how many more issues/milestones we can get resolved and made more complete! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing scheduler calls.
Removed un-used clojure.string require.
New helper function (payload-key) due to the "request" Mesos http api endpoint breaking the 1 to 1 pattern of type/payload key. (type: REQUEST, requests: payload)
Closes #7