Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/87/subscribe arg #88

Merged
merged 7 commits into from
Sep 11, 2020
Merged

Conversation

wdhowe
Copy link
Member

@wdhowe wdhowe commented Sep 2, 2020

Allow the meson.api.scheduler.core/subscribe to take an additional argument of a mesos-master in order to subscribe to remote scheduler APIs.

Closes #87

variable for the Mesos master.

Modified the core scheduler api's subscribe to accept a new argument for
the mesos-master. Adds 1 additional arity to
meson.api.scheduler/subscribe.
variable for the Mesos master.

Updated documentation to reflect different ways to call subscribe.
@wdhowe
Copy link
Member Author

wdhowe commented Sep 2, 2020

lein travis is currently failing.

"Error encountered performing task 'ancient' with profile(s): 'base,system,user,provided,dev,test'

java.io.FileNotFoundException: Could not locate clj_http/client__init.class or clj_http/client.clj on classpath. Please check that namespaces with dashes use underscores in the Clojure file name., compiling:(ancient/ancient_clj/v0v3v14/ancient_clj/io/http.clj:1:1)"

Will look into this.

@wdhowe
Copy link
Member Author

wdhowe commented Sep 3, 2020

lein check-deps (which runs lein ancient) is currently the only alias from lein travis that is failing. (All others are running successfully locally)

Current error is:
"Error encountered performing task 'ancient' with profile(s): 'base,system,user,provided,dev,test'
Suppressed exit"

lein ancient exits with a non-zero code when a library is outdated.

Avoid pipeline failures by executing 'check-deps || true' in a separate
step in order to still log the library versions.
@oubiwann
Copy link
Member

oubiwann commented Sep 3, 2020

Just wanted to leave a quick note -- I've been watching the messages come in from your work, and I'm excited to see you giving this some love!

I'm craaaaazy busy right now, and your contributions warrant a the same level of attention and care that you are putting in. So I wanted to let you know it wasn't just going into a vacuum ;-) And I wanted to encourage you to keep going!

I hope to catch up soon ...

@wdhowe
Copy link
Member Author

wdhowe commented Sep 3, 2020

Awesome, sounds good. Clay and I are starting work on a Mesos scheduler. We are planning to utilize Meson for it, so definitely expect more from both of us related to scheduler APIs.

@oubiwann oubiwann merged commit c043c70 into clojusc:master Sep 11, 2020
@oubiwann
Copy link
Member

Thanks again!

@wdhowe wdhowe deleted the issue/87/subscribe-arg branch September 11, 2020 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify subscribe function to allow passing in a variable for the Mesos master
2 participants