Optimize namespace-aliases
#328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
expez
approved these changes
Sep 17, 2021
| [:cljs (util/with-suppressed-errors | ||
| (some-fn core/cljs-file? core/cljc-file?) | ||
| ignore-errors?)]] | ||
| (repeat files))] |
Parallelizes it, and shrinks the corpus by removing non source/test dirs from the classpath. Testing it over refactor-nrepl itself, I got a performance gain from 70ms (cached case) to 20ms (cached case). The performance gains can be larger as projects scale. It also can plausibly ameliorate the mistery slowness for the :cljs branch.
vemv
force-pushed
the
optimize-namespace-aliases
branch
from
a99c08d to
7722c0e
Compare
Member
Author
|
Cheers 🍻 thanks for the eyeing! Getting closer to a new release 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes this defn via 3 techniques:
Testing it over refactor-nrepl itself, I got a performance gain from 70ms (cached case) to 20ms (cached case).
The performance gains can be larger as projects scale. It also can plausibly ameliorate the mistery slowness for the :cljs branch.
Fixes #230 (see #230 (comment))