Project analysis is constrained to .clj files

[vemv]

refactor-nrepl/src/refactor_nrepl/ns/tracker.clj

Line 98 in 0a9a6ee

core/clj-file?)

means that

refactor-nrepl/src/refactor_nrepl/analyzer.clj

Lines 141 to 150 in 0a9a6ee

	(defn warm-ast-cache []
	(doseq [f (tracker/project-files-in-topo-order true)]
	(try
	(ns-ast (slurp f))
	(catch Throwable th
	(when (System/getProperty "refactor-nrepl.internal.log-exceptions")
	(-> th .printStackTrace))
	nil ; noop, ast-status will be reported separately
	)))
	(ast-stats))

will only see .clj files.

That's mostly desired behavior, since tools.analyzer only works for JVM Clojure.

However, we could also pick up .cljc files and tell tools.analyzer, if needed, to read them with :read-cond :allow :features #{:clj}.

This would result in a more complete analysis which therefore would be less prone to errors.

[vemv]

...I wrote something but deleted it.

Here goes a more accurate analysis:

• slurp in the snippet above is used but for relatively minor purposes (parsing the ns and aliases)
  • worth updating slurp to a proper tools.reader/read reader-opts, so that we can also parse .cljc files
• the main analysis is performed in

  refactor-nrepl/src/refactor_nrepl/analyzer.clj

  Line 94 in c1ff3fe

  (assoc-in (aj/analyze-ns ns (aj/empty-env) opts) [0 :alias-info] aliases))))))

  • this already implies tools.reader/read with :features #{:clj
  • so there's nothing to do here
• after fixing the first bullet point, it's safe to fix

  refactor-nrepl/src/refactor_nrepl/ns/tracker.clj

  Line 98 in 0a9a6ee

  core/clj-file?)

  to also include .cljc files.