Fix clojure-thread-last-all breaking forms with line comments#698
Open
Fix clojure-thread-last-all breaking forms with line comments#698
Conversation
The dangling-parens join in clojure--thread-last would merge closing parens onto a line ending in a comment, absorbing them into the comment and making the form invalid. Now checks for a preceding comment before joining.
bbatsov
force-pushed
the
fix-thread-comments
branch
from
a081b44 to
e8cef56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #619
The dangling-parens fix in
clojure--thread-lastwouldjoin-lineclosing parens onto a line ending in a comment, absorbing them into the comment and making the form invalid. Now checks for a preceding line comment before joining.