Makes clojure-test-maybe-enable more discriminating. #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will only enable clojure-test-mode if it finds clojure.test somewhere in the file. This will prevent clojure-test-mode getting enabled for namespaces with 'test.' in their name that are for other testing frameworks. It will also allow clojure-test-mode to co-exist with emacs modes for those other frameworks. (I thinking specifically of conjecture-mode.)
| (let ((ns (clojure-find-package))) ; defined in clojure-mode.el | ||
| (when (and ns (string-match "test\\(\\.\\|$\\)" ns)) | ||
| (let ((res (clojure-find-clojure-test))) | ||
| (when (and res (string-match "clojure\\.test" res)) |
There was a problem hiding this comment.
why aren't you using the clojure-test-regex here?
|
+1, lgtm |
|
+1 |
pjstadig
added a commit
that referenced
this pull request
May 25, 2013
…able Makes clojure-test-maybe-enable more discriminating.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will only enable clojure-test-mode if it finds clojure.test somewhere in the
file. This will prevent clojure-test-mode getting enabled for namespaces with
'test.' in their name that are for other testing frameworks.
It will also allow clojure-test-mode to co-exist with emacs modes for those
other frameworks. (I thinking specifically of conjecture-mode.)