Skip to content

Fix errors on empty stacktraces #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2021

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented Sep 1, 2021

Fixes #3022, succeeds #3023.

I also edited the docs to reflect that Cider no longer throws an error, and added beginner-friendly instructions for setting the JVM opts.
Note: only added examples for Clojure CLI, since Leiningen enables the flag by default and I'm not familiar with Boot.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@@ -269,16 +269,10 @@ counting from 0 while Clojure starts from 1. Accordingly, the `cider-nrepl`
middleware uses 1-based indexing and all conversions to 0-based indexing should
be handled client-side. See https://github.com/clojure-emacs/cider/issues/2852.

=== Empty Java stacktraces resulting in `NullPointerException`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I removed this clause since it's not clear that the stacktraces are only omitted for NPEs or cause them to occur)

@bbatsov bbatsov merged commit 215929a into clojure-emacs:master Sep 2, 2021
@bbatsov
Copy link
Member

bbatsov commented Sep 2, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIDER 1.1.1 Can't Handle Errors Without Stack Traces
2 participants