Sideloader: handle binary files, support multiple directories

[plexus]

Make sure that files are served byte-for-byte as they are on disk, without emacs
doing any coding system conversion. This also prevents base64-encode from
complaining about multibyte characters.

Support multiple directories as sources for the sideloader, e.g.
cider-nrepl/src, cider-nrepl/resources, orchard/src

Part of #3037

Discovered this because cider.nrepl.middleware.track-state contains a U+2019 RIGHT SINGLE QUOTATION MARK :)

---

• The commits are consistent with our contribution guidelines
• You've added tests (if possible) to cover your change(s)
• All tests are passing (eldev test)
• All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)
• You've updated the user manual (if adding/changing user-visible functionality)

[plexus]

Oops there's actually another important change in there, I should split that up. (serving from multiple directories)

[bbatsov]

I think the missing . is breaking the CI.

[bbatsov]

Discovered this because cider.nrepl.middleware.track-state contains a U+2019 RIGHT SINGLE QUOTATION MARK :)

Wow! 🤣

Support multiple directories as sources for the sideloader, e.g., cider-nrepl/src, cider-nrepl/resources, orchard/src

Seems you've address my comment from the meta issue already. :D Probably we should make this eventually a defcustom to which we always append CIDER's source dir + lib (or something along those lines).

Seems the win build has hit some CircleCI limit... No love for OSS. :-)

[plexus]

That is some funny math going on at CircleCI

[plexus]

The linting is fixed. The windows builds are still red but that just seems to be a CircleCI limit we've hit.

[bbatsov]

That's pretty weird, as supposedly we should get a pretty high limit on an OSS plan https://circleci.com/open-source/ I guess I'll have to contact their support (if they provide any for the OSS projects).

[plexus]

My contact at CircleCI says the limits for Windows builds are different since they're more expensive. Seems we should use them sparingly.

• Do we need to lint separately on Windows?
• Maybe we can convert the windows jobs to GH actions?