Stop cursor moving when initialising the CIDER REPL

[simon-katz]

Fixes this bug: When cider-repl-pop-to-buffer-on-connect is nil the cursor jumps
when initialising the CIDER REPL. The cursor jumps in whatever buffer is
current.

This commit fixes commit e0aca78b, whose commit message says:

Make sure REPL window point is at point-max at startup
Needed when cider-repl-pop-to-buffer-on-connect is 'display-only

This commit applies the new functionality only when
cider-repl-pop-to-buffer-on-connect is display-only.

• The commits are consistent with our contribution guidelines
• All tests are passing (make test)
• All code passes the linter (make lint) which is based on elisp-lint and includes
  • byte-compilation, checkdoc, check-declare, packaging metadata, indentation, and trailing whitespace checks.
• You've updated the changelog (if adding/changing user-visible functionality)

The following are not done, but I think they're not applicable.

• You've added tests (if possible) to cover your change(s)
• You've updated the user manual (if adding/changing user-visible functionality)

[manuel-uberti]

Thanks for this, it's a rather annoying thing. 👍

[cichli]

Thanks for the PR 😄!

What do you think about using get-buffer-window rather than checking the value of the option? Maybe we shouldn't ever assume that the selected window is the correct one.

    (when-let ((window (get-buffer-window)))
      (set-window-point window (point-max)))

[simon-katz]

@cichli

What do you think about using get-buffer-window rather than checking the value of the option? Maybe we shouldn't ever assume that the selected window is the correct one.

I'm not sure — I don't understand the initialisation code very well.

If someone tells me it's the right thing to do, I'm happy to make the change.

EDIT 1: Oh, the buffer will always be the REPL buffer, right? So, yes, I will make this change.
EDIT 2: Done.

[cichli]

Thanks for this! 🙌