Delete overlays when clearing REPL buffer #1488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed that zombie overlays for ANSI coloring in the REPL buffer seem to impact its performance.
For example, evaluate the following code:
Then, type C-u C-c C-o to clear the repl buffer.
Finally, you can confirm empty overlays are still there by evaluating the following elisp code in the REPL buffer:
In my case, the number of zombie overlays reached more than 20000 after long working and REPL buffer's response was very slow.
In this PR, I tweaked
cider-repl-clear-output
andcider-repl-clear-buffer
to remove overlays.