Regression in stacktrace font-locking

[jeffvalk]

401e819 changed uses of face to font-lock-face, including here. This may have fixed a larger font-lock compatibility issue, but it disabled font-locking of stack frame detail: the face set here overrides those uses of font-lock-face.

[bbatsov]

It's amazing no one noticed this for over one year.

[bbatsov]

You might want to mention the fix in the changelog as well.

[jeffvalk]

That's what I thought too. Maybe everyone is just conditioned to ugly errors. For all Clojure's awesomeness, errors are still not sane.

On the other hand, the updates to CIDER in the last year are really fantastic. Seriously great stuff!

[cap10morgan]

I'm trying to test that this is fixed in the v0.10 branch, but I'm not 100% sure how to reproduce it. Can someone post some simple reproduction steps? Thanks!

[jeffvalk]

If the file, line number, namespace/class, and function/method for stacktrace frames all appear with the same face, you're seeing this issue. If the function name is in bold and the ns is fontified as a comment, you're seeing the fix.

[cap10morgan]

@jeffvalk Thanks, looks good in that case.