Skip to content

Standardize test names - #366

Merged
bbatsov merged 1 commit into
clojure-emacs:masterfrom
dpsutton:feature/rename_tests
Jul 17, 2016
Merged

Standardize test names#366
bbatsov merged 1 commit into
clojure-emacs:masterfrom
dpsutton:feature/rename_tests

Conversation

@dpsutton

Copy link
Copy Markdown
Contributor

Before submitting a PR make sure the following things have been done:

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing cljs tests are not passing. I can't tell if more or less are now though as @Malabarba mentioned there were some failing ones before
  • The new code is not generating reflection warnings
  • You've updated the readme (if adding/changing middleware)

Thanks!

@dpsutton dpsutton mentioned this pull request Jul 17, 2016
@dpsutton

Copy link
Copy Markdown
Contributor Author

Hmm. Clj passes on 1.7 for me whereas this says there's a failure for a future. The cljs stuff I'm unable to get to run on master or my branch, but the tests here just seem to almost time out, not error. But the tests error for me with the cljs profile.

@bbatsov
bbatsov merged commit eff2d42 into clojure-emacs:master Jul 17, 2016
@bbatsov

bbatsov commented Jul 17, 2016

Copy link
Copy Markdown
Member

Guess the failures were random, as restarting the build took care of them. Thanks for working on this! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants