Standardize test names - #366
Merged
Merged
Conversation
Closed
Contributor
Author
|
Hmm. Clj passes on 1.7 for me whereas this says there's a failure for a future. The cljs stuff I'm unable to get to run on master or my branch, but the tests here just seem to almost time out, not error. But the tests error for me with the cljs profile. |
Member
|
Guess the failures were random, as restarting the build took care of them. Thanks for working on this! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a PR make sure the following things have been done:
Thanks!