Skip to content

Conversation

@ckoparkar
Copy link
Contributor

@ckoparkar ckoparkar commented Jul 12, 2016

I still couldn't get the auto-complete to work for the form, (resource "|"). But that is an additional feature and does not block this upgrade. Everything else works.
I'm working on it and we can add that later. It wouldn't require any changes to the middleware.

  • The commits are consistent with our contribution guidelines
  • You've added tests to cover your change(s)
  • All tests are passing
  • The new code is not generating reflection warnings
  • You've updated the readme (if adding/changing middleware)

Thanks!

/cc @alexander-yakushev

@ckoparkar
Copy link
Contributor Author

Sorry for the confusion. I was thinking that a new resources source has been added in 0.3.
But we always had that. It's just that we do not yet parse the context which it expects. That is not related to this upgrade at all.

@bbatsov
Copy link
Member

bbatsov commented Jul 13, 2016

Looks good to me, but I'll wait to hear what @alexander-yakushev thinks about the changes as well.

@alexander-yakushev
Copy link
Member

Looks fine except for the fact that some test are failing :).

@ckoparkar
Copy link
Contributor Author

The debug-integration-tests have failed. They are a bit flaky on travis :-). All the tests were passing on my local machine.

@alexander-yakushev
Copy link
Member

Let's merge it then.

@bbatsov bbatsov merged commit 81a2e1f into clojure-emacs:master Jul 14, 2016
@bbatsov
Copy link
Member

bbatsov commented Jul 14, 2016

A couple of tests are failing locally for me:

FAIL in (complete) (complete_test.clj:13)
blank
expected: (= #{"done"} (:status response))
  actual: (not (= #{"done"} #{"complete-error" "done"}))

lein test :only cider.nrepl.middleware.complete-test/complete

FAIL in (complete) (complete_test.clj:14)
blank
expected: (sequential? (:completions response))
  actual: (not (sequential? nil))

Anyways, this is now deployed.

@ckoparkar
Copy link
Contributor Author

ckoparkar commented Jul 14, 2016 via email

@ckoparkar ckoparkar deleted the feature/update-compliment branch July 14, 2016 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants