This repository was archived by the owner on Apr 25, 2024. It is now read-only.
Make :container trait handle proxies of android.* classses #68
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, :custom-constructor doesn't appear to work for proxied container widgets:
leads to an error at runtime.
The deftrait for :container has:
So IIUC, if wdg is a proxy, kw becomes nil.
As a work-around, I added a function 'closest-android-ancestor' which tries to determine the 'closest' android.* ancestor (actually, the starting class is also considered). Replacing the aforementioned line with:
yields better results here.
Likely there's a better way :)