-
Notifications
You must be signed in to change notification settings - Fork 17
Require a minimum code gen version #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
commit: |
JulienLavocat
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add semver parsing. * Add a minimum version check. * Use qmark syntax. * Regen quickstart-chat bindings with 1.2.0 cli * Bump minimum codegen version. * Regen test app with 1.2
Description of Changes
This will throw an error if the remote module was generated with a CLI version that is too old for the typescript sdk.
API
This will now throw an error when building a db connection, rather than having arbitrary errors happen for incompatible versions.
Requires SpacetimeDB PRs
This will make master broken until clockworklabs/SpacetimeDB#2671 is released (which is the point of this PR).
Testing
There is unit testing for the sem ver logic, and anything using generated code will have some degree of coverage.