Skip to content

Conversation

@jsdt
Copy link
Contributor

@jsdt jsdt commented May 13, 2025

Description of Changes

This will throw an error if the remote module was generated with a CLI version that is too old for the typescript sdk.

API

This will now throw an error when building a db connection, rather than having arbitrary errors happen for incompatible versions.

Requires SpacetimeDB PRs

This will make master broken until clockworklabs/SpacetimeDB#2671 is released (which is the point of this PR).

Testing

There is unit testing for the sem ver logic, and anything using generated code will have some degree of coverage.

@changeset-bot
Copy link

changeset-bot bot commented May 13, 2025

⚠️ No Changeset found

Latest commit: 330babe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 13, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@clockworklabs/spacetimedb-sdk@186

commit: 330babe

@jsdt jsdt requested a review from JulienLavocat July 1, 2025 15:37
@jsdt jsdt marked this pull request as ready for review July 1, 2025 15:37
Copy link
Contributor

@JulienLavocat JulienLavocat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsdt jsdt merged commit 6ea0c6f into main Jul 7, 2025
8 checks passed
@jsdt jsdt deleted the jsdt/minimum-cli-version branch July 7, 2025 16:07
bfops pushed a commit that referenced this pull request Jul 29, 2025
* Add semver parsing.

* Add a minimum version check.

* Use qmark syntax.

* Regen quickstart-chat bindings with 1.2.0 cli

* Bump minimum codegen version.

* Regen test app with 1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants