Skip to content
This repository was archived by the owner on Aug 8, 2025. It is now read-only.

Conversation

@bfops
Copy link
Collaborator

@bfops bfops commented Apr 17, 2025

Given #317, I have now added CI to check the CLI docs on docs PRs.

That said, this is slower than the existing CI on the docs repo (it takes ~2.5m), so there are some drawbacks to merging it.

@bfops bfops requested a review from jdetter April 17, 2025 17:45
@jdetter
Copy link
Collaborator

jdetter commented Apr 17, 2025

Is your intention for this to become a required check?

@bfops
Copy link
Collaborator Author

bfops commented Apr 17, 2025

Is your intention for this to become a required check?

That's what I would do, yes.

Copy link
Collaborator

@jdetter jdetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated comment looks good, thanks Zeke 👍

@jdetter
Copy link
Collaborator

jdetter commented Apr 17, 2025

Is your intention for this to become a required check?

That's what I would do, yes.

No objection, after the PR merges let me know if you need me to add it as a required check 👍

@bfops bfops merged commit d32e61b into master Apr 17, 2025
7 checks passed
@bfops bfops deleted the bfops/cli-ci branch April 17, 2025 17:57
bfops added a commit that referenced this pull request Aug 5, 2025
* [bfops/cli-ci]: CI - Check the CLI docs

* [bfops/cli-ci]: fix

* [bfops/cli-ci]: fix permission warnings

* [bfops/cli-ci]: review

* [bfops/cli-ci]: review

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants