Skip to content
This repository was archived by the owner on Aug 8, 2025. It is now read-only.

Conversation

@gefjon
Copy link
Contributor

@gefjon gefjon commented Feb 20, 2024

Re clockworklabs/SpacetimeDB#840 .

We're removing the row_pk from the WebSocket API TableRowOperation, as computing it has a major performance impact on the server.

This commit removes references to it from the WebSocket API reference.

Re clockworklabs/SpacetimeDB#840 .

We're removing the `row_pk` from the WebSocket API `TableRowOperation`,
as computing it has a major performance impact on the server.

This commit removes references to it from the WebSocket API reference.
Copy link
Collaborator

@bfops bfops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to argue with that!

@bfops bfops merged commit 4a50e1c into master Feb 28, 2024
@bfops
Copy link
Collaborator

bfops commented Feb 28, 2024

wait - should we have merged off on merging this until releasing? What's our process around coordinating docs with code?

bfops pushed a commit that referenced this pull request Aug 5, 2025
Re clockworklabs/SpacetimeDB#840 .

We're removing the `row_pk` from the WebSocket API `TableRowOperation`,
as computing it has a major performance impact on the server.

This commit removes references to it from the WebSocket API reference.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants