Faster deserialization #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazimuth
force-pushed
the
jgilles/faster-deser
branch
from
270b053 to
c92a633
Compare
Contributor
Author
|
Test failures seem to be because Unity is getting more aggressive with their license enforcement... |
Contributor
Author
|
I have tested this in BitCraft and am happy with it. |
kazimuth
commented
May 15, 2025
rekhoff
approved these changes
May 15, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
The reasoning here makes sense and is a well documented justification. I don't seen any issues with this, approved.
bfops
pushed a commit
that referenced
this pull request
Jul 28, 2025
## Description of Changes Leverages clockworklabs/SpacetimeDB#2725 to speed up row deserialization. Also updates DLLs for recent upstream fixes. Changes: - Uses much simpler code when deserializing enums, avoiding the use of reflection - Uses manually monomorphized row deserialization methods, which again avoid the use of reflection when constructing row objects ## API - [ ] This is an API breaking change to the SDK *If the API is breaking, please state below what will break* ## Requires SpacetimeDB PRs clockworklabs/SpacetimeDB#2725 ## Testsuite SpacetimeDB branch name: jgilles/perf/faster-allocation ## Testing *Write instructions for a test that you performed for this PR* - [x] Blackholio - [x] Bitcraft (have done a basic test but no in-depth testing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Leverages clockworklabs/SpacetimeDB#2725 to speed up row deserialization. Also updates DLLs for recent upstream fixes.
Changes:
API
If the API is breaking, please state below what will break
Requires SpacetimeDB PRs
clockworklabs/SpacetimeDB#2725
Testsuite
SpacetimeDB branch name: jgilles/perf/faster-allocation
Testing
Write instructions for a test that you performed for this PR