Shrink JsWorkerRequest & use the right HashMap/Set#4150
Merged
Conversation
Centril
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
bfops
approved these changes
Jan 28, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
my code-owned changes (CLI) look good to me, although I don't know that this distinction really matters in there since it's very not-performance-sensitive.
I don't think I'm the right reviewer for most of the rest of the codebase.
Shubham8287
approved these changes
Jan 29, 2026
Centril
force-pushed
the
centril/shrink-jsreq
branch
from
8872018 to
b11287e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR shrinks
JsWorkerRequestso that it is (almost) as small as the call reducer request.To do that, a bunch of trivial changes had to be done to auth code, that mostly revolves around
String->Box<str>.This should help the auth code, but that is incidental.
The main goal was to improve throughput through the request tx/rx channel for V8, which is taking quite a bit of time in flamegraphs.
I also noticed while making this change that the wrong hash map was being used in a bunch of places, so I fixed all of those.
A follow up PR will shrink the reply side to fit within a cache line.
Yet another follow up PR will change the channel to replace flume with
fibre::spsc.API and ABI breaking changes
None
Expected complexity level and risk
2, fairly trivial changes.
Testing
Covered by existing tests.