fix: docs llm test. make tables that we sql query public#4058
Merged
bfops merged 2 commits intoclockworklabs:masterfrom Jan 20, 2026
Merged
fix: docs llm test. make tables that we sql query public#4058bfops merged 2 commits intoclockworklabs:masterfrom
bfops merged 2 commits intoclockworklabs:masterfrom
Conversation
Contributor
|
@Boegie19 I don't think we should update the answers to expect public be explicit. Public is (or should be) the default. If it is not we should fix that instead. |
Contributor
It isn't, and changing this would be a major security breaking change for existing codebases, which I'm sure should not happen unless bumping to 2.0 and providing a source migration tool. |
Contributor
|
Sorry! I am a fool! They are private by default, not public. |
cloutiertyler
approved these changes
Jan 16, 2026
Contributor
Author
|
@cloutiertyler Can you run /update-llm-benchmark ? if it works. |
Signed-off-by: Boegie19 <34578426+Boegie19@users.noreply.github.com>
Merged
via the queue into
clockworklabs:master
with commit Jan 20, 2026
6273d8e
38 of 39 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
in the llm tests we run to see if docs update break llms.
we are making sql queries to tables that we did not set to public what means the sql query will fail
API and ABI breaking changes
Expected complexity level and risk
1
Testing
Run /update-llm-benchmark and see if it fixes the sql query issues.