Skip to content

Comments

Make Uuid Nameable#4011

Merged
bfops merged 4 commits intoclockworklabs:masterfrom
kistz:nameable-uuid
Jan 13, 2026
Merged

Make Uuid Nameable#4011
bfops merged 4 commits intoclockworklabs:masterfrom
kistz:nameable-uuid

Conversation

@kistz
Copy link
Contributor

@kistz kistz commented Jan 12, 2026

Description of Changes

Implements the Nameable interface for the generated uuid client bindings.

API and ABI breaking changes

None.

Expected complexity level and risk

  1. Only additive changes pretty much copy pasted from the other types where it was already implemented.

Testing

  • Before it didnt work in my project now it works

Copy link
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link
Contributor

@egormanga egormanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a friendly lint for you

@kistz
Copy link
Contributor Author

kistz commented Jan 12, 2026

Yeah sorry guys forgot to do that 😓should be good now :> orrrr my pnpm format is broken idk xD

@egormanga
Copy link
Contributor

egormanga commented Jan 12, 2026

orrrr my pnpm format is broken idk

Yeah, it just added a bunch of unrelated changes for some reason (those are all valid, though).

@kistz
Copy link
Contributor Author

kistz commented Jan 12, 2026

As discussed with @cloutiertyler on discord we decieded to check in all the files that currently fail formatting

You can still review commit per commit to make it easier 👍

@kistz
Copy link
Contributor Author

kistz commented Jan 13, 2026

This is ready to review and good to merge 👍
my statement yesterday in the stream that something is afoot with the react hooks can be discarded :>
(well technically its still not working to do where(eq("uuidField", "im-a-uuid")) but this is a separate limitation in the react hooks which i will try to do in a followup.
This pr fixes the way more critical bug that the ts sdk is not even compiling because of the missing nameable 😇

@bfops bfops enabled auto-merge January 13, 2026 18:30
@bfops bfops disabled auto-merge January 13, 2026 18:38
@bfops bfops added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@bfops bfops added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@bfops bfops added this pull request to the merge queue Jan 13, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
# Description of Changes

Implements the `Nameable` interface for the generated uuid client
bindings.

# API and ABI breaking changes
None.

# Expected complexity level and risk

1. Only additive changes pretty much copy pasted from the other types
where it was already implemented.

# Testing

- [x] Before it didnt work in my project now it works

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@bfops bfops added this pull request to the merge queue Jan 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@bfops bfops added this pull request to the merge queue Jan 13, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 13, 2026
# Description of Changes

Implements the `Nameable` interface for the generated uuid client
bindings.

# API and ABI breaking changes
None.

# Expected complexity level and risk

1. Only additive changes pretty much copy pasted from the other types
where it was already implemented.

# Testing

- [x] Before it didnt work in my project now it works

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 13, 2026
@bfops bfops added this pull request to the merge queue Jan 13, 2026
Merged via the queue into clockworklabs:master with commit 7698f70 Jan 13, 2026
22 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jan 21, 2026
# Description of Changes

Dpends on and includes: #4011 
Will remove commits whenever that merges 👍 

This impacts the `useTable()` functions `where`clause.
We add a new possibility for the `Value` type which is the new `Uuid`
type.


Also my formatter is bugging again :( whenever i `pnpm format` it does
things differently than the guidelines? Would be cool for that reason if
someone can run format for me maybe bfops like the last time :>

# API and ABI breaking changes

None

# Expected complexity level and risk

1. Only lifts the filter for the where clause a bit to further support
`Uuid` alongside bool, string, and number.

# Testing
- [x] Getting syntax highlithing for the new availbale row
- [x] Getting row back from subscription when supplying a uuid
- [x] Fix edge case with string

---------

Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
@rekhoff rekhoff mentioned this pull request Jan 23, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants