Conversation
cloutiertyler
left a comment
There was a problem hiding this comment.
This looks good to me!
egormanga
left a comment
There was a problem hiding this comment.
Just a friendly lint for you
|
Yeah sorry guys forgot to do that 😓should be good now :> orrrr my pnpm format is broken idk xD |
Yeah, it just added a bunch of unrelated changes for some reason (those are all valid, though). |
|
As discussed with @cloutiertyler on discord we decieded to check in all the files that currently fail formatting You can still review commit per commit to make it easier 👍 |
|
This is ready to review and good to merge 👍 |
# Description of Changes Implements the `Nameable` interface for the generated uuid client bindings. # API and ABI breaking changes None. # Expected complexity level and risk 1. Only additive changes pretty much copy pasted from the other types where it was already implemented. # Testing - [x] Before it didnt work in my project now it works --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
# Description of Changes Implements the `Nameable` interface for the generated uuid client bindings. # API and ABI breaking changes None. # Expected complexity level and risk 1. Only additive changes pretty much copy pasted from the other types where it was already implemented. # Testing - [x] Before it didnt work in my project now it works --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
# Description of Changes Dpends on and includes: #4011 Will remove commits whenever that merges 👍 This impacts the `useTable()` functions `where`clause. We add a new possibility for the `Value` type which is the new `Uuid` type. Also my formatter is bugging again :( whenever i `pnpm format` it does things differently than the guidelines? Would be cool for that reason if someone can run format for me maybe bfops like the last time :> # API and ABI breaking changes None # Expected complexity level and risk 1. Only lifts the filter for the where clause a bit to further support `Uuid` alongside bool, string, and number. # Testing - [x] Getting syntax highlithing for the new availbale row - [x] Getting row back from subscription when supplying a uuid - [x] Fix edge case with string --------- Co-authored-by: Zeke Foppa <bfops@users.noreply.github.com>
Description of Changes
Implements the
Nameableinterface for the generated uuid client bindings.API and ABI breaking changes
None.
Expected complexity level and risk
Testing